FlayHooks.sol

The FeeSplitManager powers the core logic for fee splitting manager integrations. The main logic of this contract is the power the _claim call and to define the virtual functions needed to process that _claim.

[INFO] EnumerableSet Imported But Not Used

The EnumerableSet library is imported from OpenZeppelin and the contract is using EnumerableSet for EnumerableSet.UintSet, but there is no usage of the library in the contract.

[INFO] Slightly Confusing Naming Conventions

The feesCreator and feesSplit variables read strange, we would recommend a better naming convention would be creatorFees and splitFees.

[MEDIUM] Misallocated Fees Will Result In Lost ETH

If fees are deposited into the FeeEscrow with a mismatched PoolId then the fees can be claimed by the manager and the creator share will be captured, but no creator will actually be attributed this share. This will result in fees being lost and unclaimable from the contract.

[INFO] Potential Reentrancy Attack

When dispatching revenue, depending on the implementation, there could be a reentrancy attack vector. The current implementation appears to avoid this by modifying state before anything is transferred, but as this contract is aimed expected to be extended, it is likely worth implementing a reentrancy guard internally.